Determine indent level from more modes #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
force-pushed
the
fix/more-js-y-indent-modes
branch
2 times, most recently
from
a1dffeb to
5b38be9
Compare
|
Reworked against current main branch. |
scop
changed the title
scop
force-pushed
the
fix/more-js-y-indent-modes
branch
from
5b38be9 to
4d83c23
Compare
scop
changed the title
scop
force-pushed
the
fix/more-js-y-indent-modes
branch
2 times, most recently
from
72850c4 to
9e5f03e
Compare
Namely `graphql-mode`, `html-mode`, `ruby-mode`, `ruby-ts-mode`, `svelte-mode`, and `yaml-mode`.
scop
force-pushed
the
fix/more-js-y-indent-modes
branch
from
9e5f03e to
a79f027
Compare
raxod502
previously approved these changes
Dec 15, 2023
|
At least we got that pesky variable renamed though with the refactor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass CSS, GraphQL, HTML, Ruby, Svelte, and YAML mode indent setting to formatters that make use of it through
apheleia-formatters-js-indent.prettier-markdownandprettier-scssattempt to make use of this too, butmarkdown-modeandscss-modedon't have such a setting that I can tell. Left the uses in place forindent-tabs-modesupport anyway.BTW the
apheleia-formatters-js-indentname and its description does not seem quite spot on, as it was already being (partially unsuccessfully) (ab?)used by some modes for which "JavaScript like"ness is a bit of a stretch :)