Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links for the majority of the organizations #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dc-up42
Copy link
Contributor

@dc-up42 dc-up42 commented Jul 5, 2022

#62 (comment):

A PR to give links to the other images would be much appreciated :)

Honestly, why not 🤷‍♂️

  • Use templating to DRY the organization logo HTML. Please tell me if I understood the structure of the repository right and put the data to be rendered to the right place.
  • Add links to the majority of organizations. ⚠️ Pls check carefully that the links are right while reviewing! Also, pay attention to the fact that I couldn't find sites for a couple of organizations

@netlify
Copy link

netlify bot commented Jul 5, 2022

Deploy Preview for tiny-gumption-84c945 ready!

Name Link
🔨 Latest commit aa5b91d
🔍 Latest deploy log https://app.netlify.com/sites/tiny-gumption-84c945/deploys/62c4c1f181c92200093422bd
😎 Deploy Preview https://deploy-preview-63--tiny-gumption-84c945.netlify.app/en/index.html
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

},
{
"class": w32,
"site": "https://en.wikipedia.org/wiki/China%E2%80%93Brazil_Earth_Resources_Satellite_program", // didn't find a better site
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention pls.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is what I'd link to, I don't know any better site.

},
{
"class": w32,
"site": "", // what is this company? could find their site
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention pls.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, they're defunct - got bought by snap (and then half the original team just got laid off in their last round). I'd say leave the logo but it's fine if there's no link.

Copy link
Collaborator

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much!

},
{
"class": w32,
"site": "", // what is this company? could find their site
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, they're defunct - got bought by snap (and then half the original team just got laid off in their last round). I'd say leave the logo but it's fine if there's no link.

},
{
"class": w32,
"site": "https://en.wikipedia.org/wiki/China%E2%80%93Brazil_Earth_Resources_Satellite_program", // didn't find a better site
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is what I'd link to, I don't know any better site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants