0.1.5

- properly handles touch event on skip button
radiantmediaplayer · May 2, 2017 · 123e6d2 · 123e6d2
1 parent dfb3b7f
commit 123e6d2
Show file tree

Hide file tree

Showing 7 changed files with 35 additions and 18 deletions.
diff --git a/js/dist/rmp-vast.debug.js b/js/dist/rmp-vast.debug.js
diff --git a/js/dist/rmp-vast.js b/js/dist/rmp-vast.js
@@ -1,6 +1,6 @@
 /**
  * @license Copyright (c) 2017 Radiant Media Player | https://www.radiantmediaplayer.com
- * rmp-vast 0.1.4
+ * rmp-vast 0.1.5
  * GitHub: https://github.com/radiantmediaplayer/rmp-vast
  * MIT License: https://github.com/radiantmediaplayer/rmp-vast/blob/master/LICENSE
  */
@@ -1046,7 +1046,13 @@ var _onTimeupdateCheckSkip = function _onTimeupdateCheckSkip() {
   }
 };
 
-var _onClickSkip = function _onClickSkip() {
+var _onClickSkip = function _onClickSkip(event) {
+  if (event) {
+    event.stopPropagation();
+    if (event.type === 'touchend') {
+      event.preventDefault();
+    }
+  }
   if (this.skippableAdCanBeSkipped) {
     // create API event
     _api.API.createEvent.call(this, 'adskipped');
@@ -1082,6 +1088,7 @@ SKIP.append = function () {
 
   this.onClickSkip = _onClickSkip.bind(this);
   this.skipButton.addEventListener('click', this.onClickSkip);
+  this.skipButton.addEventListener('touchend', this.onClickSkip);
   this.skipButton.appendChild(this.skipWaiting);
   this.skipButton.appendChild(this.skipMessage);
   this.skipButton.appendChild(this.skipIcon);
@@ -2884,6 +2891,7 @@ RESET.unwireVastPlayerEvents = function () {
     this.vastPlayer.removeEventListener('timeupdate', this.onTimeupdateCheckSkip);
     if (this.skipButton) {
       this.skipButton.removeEventListener('click', this.onClickSkip);
+      this.skipButton.removeEventListener('touchend', this.onClickSkip);
     }
     // click UI on mobile
     if (this.clickUIOnMobile) {

diff --git a/js/dist/rmp-vast.min.js b/js/dist/rmp-vast.min.js
diff --git a/js/src/creatives/skip.js b/js/src/creatives/skip.js
@@ -36,7 +36,13 @@ var _onTimeupdateCheckSkip = function () {
   }
 };
 
-var _onClickSkip = function () {
+var _onClickSkip = function (event) {
+  if (event) {
+    event.stopPropagation();
+    if (event.type === 'touchend') {
+      event.preventDefault();
+    }
+  }
   if (this.skippableAdCanBeSkipped) {
     // create API event
     API.createEvent.call(this, 'adskipped');
@@ -72,6 +78,7 @@ SKIP.append = function () {
 
   this.onClickSkip = _onClickSkip.bind(this);
   this.skipButton.addEventListener('click', this.onClickSkip);
+  this.skipButton.addEventListener('touchend', this.onClickSkip);
   this.skipButton.appendChild(this.skipWaiting);
   this.skipButton.appendChild(this.skipMessage);
   this.skipButton.appendChild(this.skipIcon);

diff --git a/js/src/rmp-vast-header.js b/js/src/rmp-vast-header.js
@@ -1,6 +1,6 @@
 /**
  * @license Copyright (c) 2017 Radiant Media Player | https://www.radiantmediaplayer.com
- * rmp-vast 0.1.4
+ * rmp-vast 0.1.5
  * GitHub: https://github.com/radiantmediaplayer/rmp-vast
  * MIT License: https://github.com/radiantmediaplayer/rmp-vast/blob/master/LICENSE
  */
diff --git a/js/src/utils/reset.js b/js/src/utils/reset.js
@@ -125,6 +125,7 @@ RESET.unwireVastPlayerEvents = function () {
     this.vastPlayer.removeEventListener('timeupdate', this.onTimeupdateCheckSkip);
     if (this.skipButton) {
       this.skipButton.removeEventListener('click', this.onClickSkip);
+      this.skipButton.removeEventListener('touchend', this.onClickSkip);
     }
     // click UI on mobile
     if (this.clickUIOnMobile) {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "rmp-vast",
-  "version": "0.1.4",
+  "version": "0.1.5",
   "author": "Radiant Media Player <[email protected]>",
   "description": "A client-side JavaScript solution to load, parse and display VAST resources (advertising)",
   "repository": {