Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced pin size by 10% #93

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Elie-Simard
Copy link
Contributor


name: Pull Request
about: Propose changes to the codebase
title: Reduce pin size by 10% #79
labels: enhancement, design
assignees: Elie Simard


Related Issues:
Closes #79

Proposed Changes:

This pull request reduces the size of the pin markers on the map by 10%. The 'icon-size' property in the addPinLayer function, previously set to 0.5 (50% of the original image size), has been changed to 0.45.

Additional Context:

The adjustment improves visual clarity by reducing marker size, allowing more space for other map elements and potentially improving performance.

Calculation:

Markers are now displayed at 45% of their original size, which is a 10% reduction from the previous size (0.5 × 0.9 = 0.45).

Copy link

netlify bot commented Aug 18, 2024

👷 Deploy request for qtmmirror pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ffe7e2a

@jokroese jokroese self-requested a review August 19, 2024 11:04
Copy link
Member

@jokroese jokroese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant – an easy one to approve!

@jokroese
Copy link
Member

And thanks for taking the time to fill in the full PR information – I appreciate it!

@jokroese jokroese merged commit 3a0ce1e into radical-data:main Aug 19, 2024
@Elie-Simard
Copy link
Contributor Author

No worries I always really loved your project! The 10% smaller doesn't make much a difference but would love to contribute more!

@jokroese
Copy link
Member

Brilliant! We're really happy to be welcoming new contributors! Your PR is a nice first: the first PR since we went open source from someone outside the 'core' team – exciting! 👯

We're in the process of creating the documentation for contributing but the short version for now is: feel free to pick any of the open issues to work on, write that you're looking at it and share your progress to avoid double work :) The issues are also places to discuss approaches so it's great to share your thoughts even if you don't know the full answer yet or don't have the time to implement it.

For example, if you're interested in a simple next issue #80 (possibly another one-liner) on fixing the map's orientation (unfortunately not so queer! but practical!) and if you fancy a bit more thought and creativity, this one is very important to the project but I haven't yet found the time to complete #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

design - reduce pin size by 10%
2 participants