fix(VisuallyHidden): Prevent unexpected scroll overflow issue by adding explicit position #3407
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cham0287
changed the title
|
+1 just ran into this problem today as well with select inside a scrolling component |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3406
This PR addresses an issue where the VisuallyHidden component could trigger unwanted scrollbars when used within containers that have
overflow-y-scrollapplied. By adding explicittop: 0andleft: 0positioning to the component, it properly constrains the element within its parent container boundaries.Changes made:
Added
top: 0andleft: 0to the inline style properties of the VisuallyHidden component