feat(Slot): mergeProps handlers should return the value of the child handler #3411
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases, we can return values from the event handlers. The best use-case I have for this is the following:
In a case like this, we can use the fact that
mutateAsync
returns aPromise
to automatically turn on a "loading" state on our button, and turn it off when the promise resolves/rejects.But if
Slot
doesn't "forward" the return value of the event child handler, this use-case becomes impossible if Button is in a Slot (that also applies an onClick handler)This PR proposes that
Slot
should return the return value of the child handler. This makesSlot
even more "transparent" to developers using it.yarn test
).yarn dev
).If you like the idea of this PR, I can try and think of tests / storybook examples