Fix a bug on windows when isHiddenFile returns an error #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows when the
isHiddenFile()
methods returns an error it is of typeos.Errno
.At another location on the code there is this particular piece of code:
where
list()
uses isHiddenFile.The problem is that
os.IsNotExist(err)
returns true foros.Errno
but fails to cast toos.PathError
which results in weird lock state because of the panic.