Skip to content

add meta #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 0-10-stable
Choose a base branch
from
Open

add meta #2438

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75e5622
add meta
Forsworn24 Oct 15, 2022
a98203c
fix meta2
Forsworn24 Oct 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/active_model_serializers/adapter/json_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,11 @@ def success_document
hash[:links].update(pagination_links_for(serializer))
end

hash[:meta] = instance_options[:meta] unless instance_options[:meta].blank?

hash[:meta] = instance_options[:meta]

if instance_options[:meta].blank?
hash[:meta] ||= {}
Copy link
Member

@bf4 bf4 Oct 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, always add document meta? If so, then no need to check blank, ||= would be find

end
hash
end
# rubocop:enable Metrics/CyclomaticComplexity
Expand Down