Skip to content

Adding 100ms minimum delay for recurring tasks #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding 100ms minimum delay for recurring tasks #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/solid_queue/recurring_task.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def create_or_update_all(tasks)
end

def delay_from_now
[ (next_time - Time.current).to_f, 0 ].max
[ (next_time - Time.current).to_f, 0.1 ].max
end

def next_time
Expand Down
2 changes: 1 addition & 1 deletion test/integration/instrumentation_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ class InstrumentationTest < ActiveSupport::TestCase

events = subscribed("enqueue_recurring_task.solid_queue") do
schedulers.each(&:start)
sleep 1.01
wait_while_with_timeout(1.1.second) { SolidQueue::RecurringExecution.count < 2 }
schedulers.each(&:stop)
end

Expand Down