fix: remote debugging

Remote debugging is still flaky
* we need to figure out a better handler of db output and application output
* relative paths eg. might be different when remote debugging

package.json

@@ -171,6 +171,7 @@
 						"name": "Perl-Debug remote",
 						"program": "${workspaceFolder}/${relativeFile}",
             "root": "${workspaceRoot}/",
+            "stopOnEntry": true,
             "port": 5000
 					}
 				]

src/adapter.ts

@@ -241,6 +241,11 @@ export class perlDebuggerConnection {
 			}
 		});
 
+		if (res.exception || res.finished) {
+			// Close the connection to perl debugger
+			this.perlDebugger.kill();
+		}
+
 		if (res.exception) {
 			if (typeof this.onException === 'function') {
 				try {
@@ -339,6 +344,11 @@ export class perlDebuggerConnection {
 
 		// Depend on the data dumper for the watcher
 		// await this.streamCatcher.request('use Data::Dumper');
+		await this.streamCatcher.request('$DB::single = 1;');
+		if (options.port) {
+			//
+			await this.streamCatcher.request('select($DB::OUT);');
+		}
 
 		// Listen for a ready signal
 		const data = await this.streamCatcher.isReady()

src/localSession.ts

@@ -27,7 +27,7 @@ export class LocalSession implements DebugSession {
 				...options.env,
 			},
 		};
-
+        // print $DB::OUT eval { require PadWalker; PadWalker->VERSION(0.08) }
 		const session = spawn(perlCommand, commandArgs, spawnOptions);
 		this.stdin = session.stdin;
 		this.stdout = session.stdout;

src/regExp.ts

@@ -49,4 +49,6 @@ export const codeErrorSyntax = /^syntax error at (\S+) line ([0-9]+), near ([\S|
 export const codeErrorRuntime = /([\S|\s]+) at (\S+) line ([0-9]+)\.$/;
 
 // EG. PadWalker for scope investigation
-export const codeErrorMissingModule = /^(\S+) module not found - please install$/;
+export const codeErrorMissingModule = /^(\S+) module not found - please install$/;
+
+export const debuggerSignature = /^  DB<[0-9]+> $/;

src/remoteSession.ts

@@ -3,6 +3,7 @@ import {spawn} from 'child_process';
 import { Readable, Writable } from 'stream';
 import { EventEmitter } from 'events';
 import { DebugSession, LaunchOptions } from './session';
+import { debuggerSignature } from './regExp';
 
 export class RemoteSession implements DebugSession {
 	public stdin: Writable;
@@ -43,30 +44,52 @@ export class RemoteSession implements DebugSession {
 			} else {
 				// Already have a client connected, lets close and notify user
 				this.stdout.push(`Warning: Additional remote client tried to connect "${name}".`);
-				socket.end('Remote debugger already connected!');
+				socket.destroy('Remote debugger already connected!');
 			}
 
-			socket.on('data', data => this.stderr.push(data));
+			socket.on('data', data => {
+				const str = data.toString('utf8');
+				const signature = str.split('\n').pop();
+				// xxx: We should figure out a more stable way of differentiating between
+				// command result and application output
+				if (debuggerSignature.test(signature)) {
+					this.stderr.push(data);
+				} else {
+					this.stdout.push(data);
+				}
+			});
 
 			socket.on('end', data => {
-				client = null;
 				this.stdout.push(`Connection closed by "${name}"`);
 				this.event.emit('close', data);
+				this.kill();
 			});
 
-			socket.on('error', data => this.event.emit('error', data));
+			socket.on('error', data => {
+				this.event.emit('error', data);
+			});
 		});
 
 		server.listen(port, '0.0.0.0'); // Listen to port make it remotely available
-		server.on('error', data => this.event.emit('error', data));
+		server.on('error', data => {
+			this.event.emit('error', data);
+			this.kill();
+		});
 
 		this.on = (type, callback) => this.event.on(type, callback);
 		this.kill = () => {
-			server.close();
+			server.removeAllListeners();
 			this.event.removeAllListeners();
 			this.stdin.removeAllListeners();
 			this.stdout.removeAllListeners();
 			this.stderr.removeAllListeners();
+
+			if (client) {
+				client.destroy();
+				client = null;
+			}
+
+			server.close();
 		};
 		this.title = () => `Running debug server for remote session to connect on port "${port}"`;
 		this.dump = () => `debug server port ${port}`;