Skip to content

Commit

Permalink
Minor updates and fixes
Browse files Browse the repository at this point in the history
Turns out that Node v12 (see <https://node.green>) isn't yet available
on NVM (under that name, at least).  Also, while I didn't modify
anything in the `test` folder originally, the
`node/no-unsupported-features/es-syntax` rule threw for the `import`
statements (which technically aren't "yet" supported by _any_ Node
version for `.js` files; it's a whole [_thing_][mjs]), so I turned it
off for that folder.  Now the linting passes just fine again.

[mjs]: https://nodejs.org/api/esm.html

Signed-off-by: Jonathan Sifuentes <[email protected]>
  • Loading branch information
jayands committed Dec 31, 2018
1 parent 3923662 commit 934a5b8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"plugins": ["node"],
"rules": {
"node/exports-style": ["error", "module.exports"],
"node/no-deprecated-api": "error",
"node/no-extraneous-import": "error",
"node/no-extraneous-require": "error",
"node/no-missing-import": "error",
Expand Down
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ node_js:
- '9'
- '10'
- '11'
- '12'

install:
- yarn
Expand Down
5 changes: 5 additions & 0 deletions test/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"rules": {
"node/no-unsupported-features/es-syntax": "off"
}
}

0 comments on commit 934a5b8

Please sign in to comment.