Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get_insider_transaction_reported #1683

Closed
wants to merge 8 commits into from

Conversation

h4x0rMadness-v2
Copy link

add get_insider_transaction_reported to fetch information here

image

@ValueRaider
Copy link
Collaborator

That class already has a data object, use that. And expose function via Ticker class.

@h4x0rMadness-v2
Copy link
Author

That class already has a data object, use that. And expose function via Ticker class.

Sure, could you take a look on the latest commit? thanks

@ValueRaider
Copy link
Collaborator

ValueRaider commented Sep 22, 2023

@ValueRaider
Copy link
Collaborator

ValueRaider commented Sep 24, 2023

Looking good. But please add unit test(s) to tests/ticker.py. Purpose is to fail if someone in future breaks your code.

Then to conform to #1084 if you don't mind:

  • rebase to dev branch (plenty of guides online, or GPT4) and change target to dev
  • git squash

Then done!

@h4x0rMadness-v2 h4x0rMadness-v2 changed the base branch from main to dev September 27, 2023 14:57
@rickturner2001
Copy link
Contributor

What's the status of this PR?

@h4x0rMadness-v2
Copy link
Author

Added ut and changed target branch to dev, ready for review

@ValueRaider
Copy link
Collaborator

Where's the test?

@bot-unit
Copy link

@ValueRaider Close, please. Implemented at #1772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants