Patch keyError in #2027 #2029
Closed
Patch keyError in #2027 #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion Fix datetime conversion with mixed timezones when ignore_tz is False
|
That's not the solution. Look at the metadata. |
|
The same information as in the original PR, #2026, can be fetched from the will have the same format as most other stocks for this key. I don't know if Yahoo Finance may give differently formated metadata for the ´'currentTradingPeriod'´ key. |
|
Just add 2 unit tests: one with prepost=False, other with True. Then rebase to dev branch #1084 |
…-resampling Revert PR ranaroussi#2027, breaks with prepost=True
The new dividend repair logic looks for too big/small dividends/adjusts. Because it analyses prices, it needs prices to be consistent - this means for some exchanges, prices are converted to major currency e.g. pence -> £. These exchanges are: .L, .TA, .JO Also, multiday intervals are created by resampling adjusted 1d intervals. Related change: - _fix_prices_sudden_change() now fixes dividends with prices Other repair fixes: - add basic repair function to fix_Yahoo_returning_live_separate() to handle simple 100x price errors within same week/month - fix _fix_prices_sudden_change() false positive on real massive price drop (clue = massive volume spike) - price reconstruct fixes: - calibration: stop NaNs breaking, and detect currency unit mixup - fix a Pandas warning
Fix detecting div_adj_exceeds_prices. Fine-tune fixing div_too_big. Unit tests.
…ir-div-adjust New: repair bad dividends and div-adjusts. Plus other repair fixes.
sync dev -> main
…urrency-bug Fix price-repair-currency, logic was inverted
Fix typo in README.md ranaroussi#2038
sync main -> dev
- adding to scraper a new class FundsData. - Ticker can now reference the data via ticker.funds_data when appropriate. - Add unit tests in test_ticker.py for the funds data
implement support for funds data
Sector and Industry class to query the data available on: https://finance.yahoo.com/sectors/: - sector / industry overview - sector / industry top companies - sector / industry research reports - sector top ETFs - sector top Mutual Funds - industries within sector - industry's sector - industry's top performing companies - industry's top growth companies
Feature Proposal: Support Sector and Industry data from Markets Tab
Improve dividend repair: - detect wrong date - detect split missing from coincident dividend - improve detecting adjust contradicting price action - improve detecting when Close has adjustment (remove phantoms before, then use AdjClose -> AdjLow deltas) Stop negative 'Adj Close' triggering a 'sudden change' repair.
…v-repair Improve dividend repair
sync dev -> main
Fix unit tests contextual imports
sync main -> dev
fix keyerror with single element list passed to Tickers
…sfasting/yfinance into fix/keyerror-30min-resample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves ´KeyError´ occurrence in #2027.
Adds Try/Except statement to find keyerror and return to old code if the keyerror is triggered.