-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Market Status #2176
Market Status #2176
Conversation
Ruff is wrong by the way. The imports are used |
Ruff is right. You're looking at the wrong file. |
Yeah, hadn't read it properly. Don't know why I was even in |
Bug:
|
Fixed that, sorry its |
I currently am getting: requests.exceptions.SSLError: HTTPSConnectionPool(host='query1.finance.yahoo.com', port=443): Max retries exceeded with url: /v1/test/getcrumb (Caused by SSLError(SSLCertVerificationError(1, "[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: Hostname mismatch, certificate is not valid for 'query1.finance.yahoo.com'. (_ssl.c:1020)"))) when requesting data from yfinance. How do I stop this? |
wrong thread |
? I am only getting this with this patch. That is why it is here not on a separate issue. |
Nothing to do with this branch, and doesn't happen to me. Also your branch is riddled with bugs. |
@ValueRaider fixed bugs. |
|
What code did you use for this? And what is the actual error @ValueRaider |
commit fd309bd |
I can't tell if you are telling me to commit it or that that is the error? @ValueRaider |
I thought you were asking code version, because the code I ran is in the stack trace. I've added error message. |
I think they must have edited that API. That used to be how long that section would last (when |
Is there anything else you want me to add or change? @ValueRaider |
Like with your other branch, don't unpack the dict into class attributes, just return a dict. You can parse its values but still return a dict. |
Done @ValueRaider anything else? |
@ValueRaider Can this be merged? |
Almost, but where you parse into attributes e.g. |
What about storing it? It seems silly to reparse data every time when I feel more people will use the parsed on (especially as |
Closing as added to market summary |
Adds a class for
Market Status
. Different fromMarket Summary
although that does include part of the data.