-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config #2209
Add config #2209
Conversation
@ValueRaider what do you think? This would help with issues like #2210 |
The quantity of code changes concerns me - code bloat. Can it be done with less? I had already been thinking of a related solution for network settings but more like this:
20 LoC for everything? And consider relaxing on the docstrings - (I've not missed lang and region but that is another discussion, let's find agreement on network stuff first)
This will block you squashing commits. Better to rebase. |
Most of that is
Yes, I realize that, I was given a button to "update" the pr as I had forgotten to pull the latest dev version, but it didn't do what I thought it would. Will make a new PR if you are happy. |
Hadn't thought of this method, I would say this makes it harder to expand it though, and doesn't allow for multiple configs for different queries. I will remove most of the docstrings |
True, but unless there is big demand for this, then they can just recall |
I could have it both return a typed dict with all of the config, that way it can be stored and passed to What do you think @ValueRaider? |
Also where would you like this to go? I would put it in utils but that would result in a circular import. |
Do you think I should make a new PR with the updated version (get rid of the |
Superseded by #2216 |
Adds a new
Config
class with defaults definedAllows setting of:
Use is global so don't need to set them separately everywhere (for example you most likely would use proxy everywhere and now you just set it once)
Allows creation of custom Configs and to set them as default.
Currently is a draft as only
Ticker.history
anddownload
have it implemented