-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: wait for the provisioner to clean up PV resources #416
base: master
Are you sure you want to change the base?
Conversation
If we're unlucky, the local-path-provisioner can be killed before it has a chance to clean up orphened PVs. These may then hang around while subsequent tests run. Depending on the lexical sort order of those PVs, the `typeCheckCmd` in `runTest` may select a moribund PV, causing the test to randomly fail.
The flaky failure condition seems related the cleanup order of the storageclass. |
It's just passing the output of kustomize into kubectl delete. Every kustomize call is (re)installing the storageclass helper. This PR explicitly tags the storageclass stuff so that kubectl delete has a label to only ditch the pod & pvc before it waits on the cleanup completing. |
@derekbit is there more required to progress this? |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
@derekbit I cannot merge this - can you do the honours please? |
Sure. I'm reviewing it. No worries. Will merger it if there is no concern. Thanks you. |
@jan-g Could you resolve the conflicts? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can merge it before resolving the conflicts.
If we're unlucky, the local-path-provisioner can be killed before it has a chance to clean up orphened PVs. These may then hang around while subsequent tests run. Depending on the lexical sort order of those PVs, the
typeCheckCmd
inrunTest
may select a moribund PV, causing the test to randomly fail.