Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Main] Move auth package to the clients to make it auth client, Auth Client Init Changes #248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Main] Move auth package to the clients to make it auth client, Auth Client Init Changes #248

wants to merge 1 commit into from

Conversation

caliskanugur
Copy link
Member

  • Moves auth package to clients
  • Adds auth as a client to the rancher.Client - uses management client mainly, and uses the same session instantiated for the clients
  • Adds a new function to refresh provider access group in users
  • Adds update method to OLDAP

@caliskanugur
Move auth as a client to clients, add a new login method, update the …
5a4f296 
…existing login method default to local provider, add a new function to refresh group for users
igomez06
igomez06 reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@igomez06 igomez06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an update after last PR, but LGTM

joesims22
joesims22 approved these changes Oct 3, 2024
View reviewed changes
Copy link

@joesims22 joesims22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anupama2501
Copy link
Contributor

Have a few conflicts. could you rebase please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igomez06 igomez06 igomez06 left review comments

@anupama2501 anupama2501 anupama2501 approved these changes

@joesims22 joesims22 joesims22 approved these changes

@dasarinaidu dasarinaidu Awaiting requested review from dasarinaidu

@Priyashetty17 Priyashetty17 Awaiting requested review from Priyashetty17

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caliskanugur @anupama2501 @igomez06 @joesims22