Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Add a Quarantined Flag to the Environment Flags #298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

caliskanugur
Copy link
Member

Issue: rancher/qa-tasks/issues/1484

Problem

Currently to skip a test, t.Skip is used. To run a test, these skips in the code need to be changed/updated.

Solution

Adds a quarantined flag to the environment flags, and method to the rancher/rancher tests.

Testing

This flag will be mainly used in the integration tests. So testing will be in r/r side of this PR.

Copy link
Contributor

@igomez06 igomez06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, backports?

@caliskanugur caliskanugur changed the title Feat(flags): Add a Quarantined Flag to the Environment Flags Add a Quarantined Flag to the Environment Flags Sep 25, 2024
@caliskanugur caliskanugur changed the title Add a Quarantined Flag to the Environment Flags [main] Add a Quarantined Flag to the Environment Flags Sep 26, 2024
@caliskanugur
Copy link
Member Author

caliskanugur commented Sep 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants