-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the rancher dynamic client to use its concrete struct types #31
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid, I've got a few questions and a naming nit
5273d52
to
a69be5a
Compare
@caliskanugur Anything else needed on my end before this can be reviewed? |
dd44042
to
ab92c36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I think this looks good, we'll need to merge this as separate version bump, just to make sure there aren't any regressions in rancher.
9f9566e
to
dd1fea2
Compare
dd1fea2
to
242ed8b
Compare
Issue:
Problem
As a developer attempting to debug issues while using the dynamic client, it was difficult to follow what code implemented the underlying functions. This was due to the dynamic client functions returning the upstream k8s dynamic client types instead of the concrete ones of the rancher dynamic client.
Solution
Update the dynamic client and other references to it so that they reference the concrete rancher dynamic client types.
Testing
Was able to build locally, have not run any tests from the rancher/rancher repo that might utilize the dynamic client. Custom tests utilizing the rancher dynamic client were able to run successfully and made debugging a bit easier.
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations
There should not be regressions as this is a minor change that updates the types to the concrete ones provided in the rancher dynamic client code.
Existing / newly added automated tests that provide evidence there are no regressions: N/A