Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace schema shows repeated methods in collectionMethods #36799

Open
nwmac opened this issue Mar 8, 2022 · 6 comments · May be fixed by rancher/steve#146
Open

Namespace schema shows repeated methods in collectionMethods #36799

nwmac opened this issue Mar 8, 2022 · 6 comments · May be fixed by rancher/steve#146
Assignees
@crobby
Labels
area/frameworks kind/bug Issues that are defects reported by users or that we know have reached a real release priority/2 status/ui-blocked team/frameworks the team that is responsible for frameworks, projects, webhook, and other various areas
Milestone
v2.13.0

Comments

@nwmac
Copy link
Member

nwmac commented Mar 8, 2022 •
edited
Loading

See UI ticket:

For a standard user, the namespace schema includes repeated methods:

Looking at the response to /v1/schema/namespace, collectionMethods returns as:

"collectionMethods": [
  "GET",
  "GET",
  "GET"
],

GET should not be repeated

This may affect other resource types.
@nwmac nwmac added this to the v2.6.5 milestone Mar 8, 2022
@nwmac nwmac mentioned this issue Mar 8, 2022
Open
@gaktive gaktive added the kind/bug Issues that are defects reported by users or that we know have reached a real release label Mar 25, 2022
@Jono-SUSE-Rancher Jono-SUSE-Rancher modified the milestones: v2.6.5, v2.6.6 Apr 13, 2022
@Jono-SUSE-Rancher Jono-SUSE-Rancher added the team/hostbusters The team that is responsible for provisioning/managing downstream clusters + K8s version support label Jun 16, 2022
@Oats87
Copy link
Contributor

Oats87 commented Jun 17, 2022 •
edited
Loading

@Jono-SUSE-Rancher we're thinking this might be more of a team 1 issue, rather than team 2.

/cc @samjustus

@Oats87 Oats87 added [zube]: To Triage team/area1 and removed team/hostbusters The team that is responsible for provisioning/managing downstream clusters + K8s version support labels Jun 17, 2022
@Jono-SUSE-Rancher
Copy link
Collaborator

Yeah that's fair. I wasn't entirely certain when I assigned it. @samjustus please take a look with your team when you get a chance.

@cbron
Copy link
Contributor

cbron commented Jun 22, 2022

Bumping to 2.6.7

@cbron cbron modified the milestones: v2.6.6, v2.6.7 Jun 22, 2022
@snasovich
Copy link
Collaborator

Moving to 2.7.0 milestone as old 2.6.6 becomes 2.6.7.

@snasovich snasovich modified the milestones: v2.6.7, v2.7.0 Jun 27, 2022
@samjustus
Copy link
Collaborator

moving out of 2.7 as we have other priorities from UI team @nwmac

@samjustus samjustus removed the v2.7.0 label Sep 6, 2022
@samjustus samjustus modified the milestones: v2.7.0, v2.7.2 Sep 6, 2022
@Jono-SUSE-Rancher Jono-SUSE-Rancher modified the milestones: v2.7.2, 2023-Q1-v2.7x Jan 3, 2023
@samjustus samjustus removed this from the 2023-Q1-v2.7x milestone Jan 3, 2023
@votdev votdev linked a pull request Jan 22, 2024 that will close this issue
Open
votdev added a commit to votdev/steve that referenced this issue Jan 22, 2024
@votdev
Namespace schema does not correctly show permitted collectionMethods
22ced5d 
Fixes: rancher/rancher#36799

Signed-off-by: Volker Theile <[email protected]>
votdev added a commit to votdev/steve that referenced this issue Jan 22, 2024
@votdev
Namespace schema does not correctly show permitted collectionMethods
ae4558a 
Fixes: rancher/rancher#36799

Signed-off-by: Volker Theile <[email protected]>
votdev added a commit to votdev/steve that referenced this issue Jan 22, 2024
@votdev
Namespace schema does not correctly show permitted collectionMethods
96dbb7c 
Fixes: rancher/rancher#36799

Signed-off-by: Volker Theile <[email protected]>
votdev added a commit to votdev/steve that referenced this issue Jan 23, 2024
@votdev
Namespace schema does not correctly show permitted collectionMethods
7a749b1 
Fixes: rancher/rancher#36799

Signed-off-by: Volker Theile <[email protected]>
@samjustus samjustus added team/frameworks the team that is responsible for frameworks, projects, webhook, and other various areas and removed team/area3 labels Feb 1, 2024
@MKlimuszka MKlimuszka removed this from the v2.x - Backlog milestone May 30, 2024
@nwmac nwmac changed the title Namespace schema does not correctly show permitted collectionMethods Namespace schema shows repeated methods in collectionMethods Jun 7, 2024
@richard-cox richard-cox mentioned this issue Jun 14, 2024
Open
@MbolotSuse MbolotSuse assigned MKlimuszka and unassigned samjustus Jul 8, 2024
@MbolotSuse MbolotSuse added this to the v2.9-Next2 milestone Jul 8, 2024
@Priyashetty17
Copy link
Contributor

The following schemas (management.cattle.io.project, management.cattle.io.cluster) have duplicate entries for the GET method under collectionMethods as well.

management.cattle.io.project:

{
"id": "management.cattle.io.project",
"type": "schema",
"links": {
"collection": "…/v1/management.cattle.io.projects",
"self": "…/v1/schemas/management.cattle.io.project"
 },
"description": "Project is a group of namespaces.\nProjects are used to create a multi-tenant environment within a Kubernetes cluster by managing namespace operations,\nsuch as role assignments or quotas, as a group.",
"pluralName": "management.cattle.io.projects",
"resourceMethods": [ 4 items
"GET",
"DELETE",
"PUT",
"PATCH"
 ],
"resourceFields": null,
"collectionMethods": [ 3 items
"GET",
"GET",
"POST"
 ],
namespace:
{
"id": "namespace",
"type": "schema",
"links": {
"collection": "…/v1/namespaces",
"self": "…/v1/schemas/namespace"
 },
"description": "Namespace provides a scope for Names. Use of multiple namespaces is optional.",
"pluralName": "namespaces",
"resourceMethods": [ 4 items
"GET",
"DELETE",
"PUT",
"PATCH"
 ],
"resourceFields": null,
"collectionMethods": [ 3 items
"GET",
"GET",
"POST"
 ],

management.cattle.io.cluster:

{
"id": "management.cattle.io.cluster",
"type": "schema",
"links": {
"collection": "…/v1/management.cattle.io.clusters",
"self": "…/v1/schemas/management.cattle.io.cluster"
 },
"pluralName": "management.cattle.io.clusters",
"resourceMethods": [ 4 items
"GET",
"blocked-DELETE",
"blocked-PUT",
"blocked-PATCH"
 ],
"resourceFields": null,
"resourceActions": {
"apply": {
"input": "applyInput",
"output": "applyOutput"
 },
"generateKubeconfig": {
"output": "generateKubeconfigOutput"
 }
 },
"collectionMethods": [ 3 items
"GET",
"GET",
"blocked-POST"
 ],

@MbolotSuse MbolotSuse modified the milestones: v2.9-Next1, v2.9-Next2 Aug 2, 2024
@MKlimuszka MKlimuszka removed their assignment Aug 12, 2024
@MKlimuszka MKlimuszka modified the milestones: v2.9-Next2, v2.10.0 Aug 14, 2024
@MKlimuszka MKlimuszka modified the milestones: v2.10.0, v2.10.1 Oct 8, 2024
@MKlimuszka MKlimuszka modified the milestones: v2.10.1, Unscheduled, v2.13.0 Nov 8, 2024
@crobby crobby self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crobby crobby

Labels
area/frameworks kind/bug Issues that are defects reported by users or that we know have reached a real release priority/2 status/ui-blocked team/frameworks the team that is responsible for frameworks, projects, webhook, and other various areas
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging a pull request may close this issue.

Namespace schema does not correctly show permitted collectionMethods votdev/steve