Namespace schema does not correctly show permitted collectionMethods #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
votdev
force-pushed
the
issue_36799_uniq_collectionmethods_dup
branch
3 times, most recently
from
ae4558a to
96dbb7c
Compare
Fixes: rancher/rancher#36799 Signed-off-by: Volker Theile <[email protected]>
votdev
force-pushed
the
issue_36799_uniq_collectionmethods_dup
branch
from
96dbb7c to
7a749b1
Compare
votdev
commented
Jan 24, 2024
| @@ -162,6 +180,8 @@ func (c *Collection) schemasForSubject(access *accesscontrol.AccessSet) (*types. | |||
| continue | |||
| } | |||
|
|
|||
| s.CollectionMethods = uniq(s.CollectionMethods) | |||
There was a problem hiding this comment.
Maybe this call can be moved to https://github.com/votdev/steve/blob/7a749b127d4fa57af225a7c209ee0d0bb7beed73/pkg/schema/factory.go#L166, but i'm not sure how it is possible to get 3 GET entries (see here) in the slice in that case (i assume only 2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is not using the Go slices package because this requires two calls (
SortandCompact) which is too expensive.Fixes: rancher/rancher#36799