Imperative api pls #434
Merged
Imperative api pls #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bigkevmcd adding you since you had reviewed the other one previously. |
tomleb
previously approved these changes
Jan 8, 2025
There was a problem hiding this comment.
LGTM
One thing I'd like to have as test in the future is running the API server with the APIService configured so that we can verify a few things when going through the main kubeapiserver (eg: ensuring user, groups and extras headers are properly propagated). This would require running a pod as an integration test (or potentially we can do that when RDP work is done).
bigkevmcd
reviewed
Jan 9, 2025
crobby
reviewed
Jan 27, 2025
| // NewUnionAuthenticator creates a [UnionAuthenticator]. | ||
| // | ||
| // The authenticators will be tried one by one, in the order they are given, until | ||
| // one succeed or all fails. |
There was a problem hiding this comment.
"one succeeds or all fail" ??
crobby
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rancher/rancher#47540
Replaces #316