vai: do not discard closing statement errors #462
Conversation
Signed-off-by: Silvio Moioli <[email protected]>
pkg/sqlcache/informer/indexer.go
Outdated
| defer func() { | ||
| cerr := i.CloseStmt(stmt) | ||
| if cerr != nil { | ||
| err = errors.Join(err, cerr) |
There was a problem hiding this comment.
Does the error message from cerr provide enough context to know that it came from this close statement call (or just allow us to troubleshoot)?
There was a problem hiding this comment.
Hopefully, but that really depends on the SQLite library implementation.
I could add the statement as context if you prefer that way.
There was a problem hiding this comment.
if it's not too much trouble yes that'd be great to have a bit more context, just in case.
There was a problem hiding this comment.
addressed as 7d290ce
TIL: the current library actually never returns errors on close - but I still feel like this code is good to have, as it might change and/or we might switch to another library which might
current https://gitlab.com/cznic/sqlite/-/blob/v1.34.5/sqlite.go#L472-479
possible https://github.com/mattn/go-sqlite3/blob/7658c06970ecf5588d8cd930ed1f2de7223f1010/sqlite3.go#L1896-L1915
Signed-off-by: Silvio Moioli <[email protected]>
Errors in deferred
CloseStmtcalls are currently ignored.This patch captures such errors and returns them (possibly joined with another error if it happened).
Part of rancher/rancher#47825