Fix: Improve render-style 'view' collapse-expand all action behaviour #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrijeret
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request on a public repo - so apologies if I make mistakes here.
Currently when you use render-style 'view' and click on "Collapse all" or "Expand all" , then only the CSS values are modified. This will cause a tiny glitch when clicking section tag headers.
If you click the section tag headers then the tag's 'expanded' state gets updated. If the state is misaligned with reality, then you have to double click the header in order for it to actually expand or collapse.
The global collapse and expand should update all tag states instead of editing CSS classes directly in DOM and making JS state and DOM not align.