Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notes->AKA for EquationGroup codenames #19900

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jvoisin
Copy link
Contributor

@jvoisin jvoisin commented Feb 23, 2025

@jvoisin
Copy link
Contributor Author

jvoisin commented Feb 23, 2025

  1) modules it should behave like all modules with module type can be instantiated exploit unix/webapp/phpbb_highlight behaves like a module with valid metadata verifies modules metadata
     Failure/Error: expect(validator.errors.full_messages).to be_empty
       expected `["Stability must have CRASH_SAFE value if module has an ExcellentRanking, instead found []"].empty?` to be truthy, got false
     Shared Example Group: "a module with valid metadata" called from ./spec/support/shared/examples/all_modules_with_module_type_can_be_instantiated.rb:35
     Shared Example Group: "all modules with module type can be instantiated" called from ./spec/modules_spec.rb:16
     # ./spec/support/shared/examples/a_module_with_valid_metadata.rb:8:in `block (2 levels) in <top (required)>'

No idea how this could remotely be related to my changes :<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant