Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Region select #738

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[3.x] Region select #738

wants to merge 12 commits into from

Conversation

Jade-GG
Copy link
Collaborator

@Jade-GG Jade-GG commented Feb 20, 2025

In Magento, for some countries it may be required to add a region (this is customizable in the configuration). Because it is possible---and we ran into a case where it's necessary---I have implemented a basic version here.

Because of the way we structured input components, it seemed cleanest to me to use a has selector to hide the region select when there are no regions. This is, however, only supported in browsers from 2023 and later. Older browsers will see an empty "region" block, which is not breaking. Also requires a tailwindcss version bump (from ^3.3.3 to ^3.4).

This will also have to be added into checkout-theme (and confira).

royduin
royduin previously approved these changes Feb 20, 2025
Copy link
Member

@royduin royduin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, let's wait for @indykoning his review.

indykoning
indykoning previously approved these changes Feb 24, 2025
@royduin
Copy link
Member

royduin commented Feb 25, 2025

We also need this within:

  • rapidez/account
  • rapidez/checkout-theme
  • rapidez/confira

Is there a follow-up? Should we merge this one first?

@Jade-GG
Copy link
Collaborator Author

Jade-GG commented Feb 25, 2025

We also need this within:

* rapidez/account

* rapidez/checkout-theme

* rapidez/confira

Is there a follow-up? Should we merge this one first?

Correct, I will follow up on these after this one has been approved. Looks like it has been approved now, so expect these pull requests soon™

royduin
royduin previously approved these changes Feb 25, 2025
@Jade-GG Jade-GG dismissed stale reviews from royduin and indykoning via 965cf9a February 28, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants