-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Region select #738
base: master
Are you sure you want to change the base?
[3.x] Region select #738
Conversation
… into feature/region-select
Co-authored-by: Roy Duineveld <[email protected]>
Co-authored-by: Roy Duineveld <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me, let's wait for @indykoning his review.
We also need this within:
Is there a follow-up? Should we merge this one first? |
Correct, I will follow up on these after this one has been approved. Looks like it has been approved now, so expect these pull requests soon™ |
In Magento, for some countries it may be required to add a region (this is customizable in the configuration). Because it is possible---and we ran into a case where it's necessary---I have implemented a basic version here.
Because of the way we structured input components, it seemed cleanest to me to use a
has
selector to hide the region select when there are no regions. This is, however, only supported in browsers from 2023 and later. Older browsers will see an empty "region" block, which is not breaking. Also requires a tailwindcss version bump (from ^3.3.3 to ^3.4).This will also have to be added into checkout-theme (and confira).