Workaround thrust-copy-if limit in wordpiece-tokenizer #12168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12168 +/- ##
===============================================
Coverage ? 88.26%
===============================================
Files ? 137
Lines ? 22586
Branches ? 0
===============================================
Hits ? 19935
Misses ? 2651
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
rerun tests |
davidwendt
added
3 - Ready for Review
davidwendt
requested review from
vyasr and
ttnghia
and removed request for
a team
ttnghia
reviewed
Nov 18, 2022
ttnghia
approved these changes
Nov 18, 2022
vyasr
approved these changes
Nov 23, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Workaround in nvtext's wordpiece-tokenizer due to limitation in
thrust::copy_ifwhich fails if the input-iterator spans more than int-max.Found existing thrust issue: NVIDIA/cccl#747
This calls the
thrust::copy_ifin chunks if the iterator can span greater than int-max.Found while working on #12079
Checklist