Use new rapids-logger library #17899
Conversation
vyasr
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
bot
added
libcudf
|
/ok to test |
vyasr
force-pushed
the
feat/rapids_logger_library
branch
from
8095a12 to
d359c37
Compare
|
/ok to test |
vyasr
force-pushed
the
feat/rapids_logger_library
branch
from
d359c37 to
c6cd7a2
Compare
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
vyasr
requested review from
gforsyth,
wence-,
Matt711,
karthikeyann and
pmattione-nvidia
|
I'm working on a local repro of the spark-rapids-jni build. I won't merge this before I can figure out if there's a real problem there. The code in this PR itself should be good to go, though. |
| @@ -12,6 +12,8 @@ | |||
| # the License. | |||
| # ============================================================================= | |||
| file(READ "${CMAKE_CURRENT_LIST_DIR}/VERSION" _rapids_version) | |||
| set(rapids-cmake-repo "vyasr/rapids-cmake") | |||
There was a problem hiding this comment.
Is that right?
| set(rapids-cmake-repo "vyasr/rapids-cmake") | |
| set(rapids-cmake-repo "feat/rapids-cmake") |
There was a problem hiding this comment.
This is correct. It's pointing at my fork of rapids-cmake. The line below is the branch. However, this will get reverted before we merge, it's only there right now for testing purposes.
|
Something is off for the installation of the static library build of rapids-logger. I'll look into that tomorrow. |
|
I resolved the spark-rapids issue in rapidsai/rapids-cmake@ae4cb7f. I just kicked off an updated build of rmm based on that commit, then I'll rerun CI here for a final test and then we should be good to start merging up the chain. |
The remaining spark-rapids-jni issue won't be fixed until the upstream PRs in rapids-cmake and rmm get merged. |
Description
Contributes to rapidsai/build-planning#104.
Checklist