Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install duckdb the default backend for ibis in the cudf.pandas integration tests #17972

Open
wants to merge 11 commits into
base: branch-25.04
Choose a base branch
from

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Feb 10, 2025

Follows up #17945

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 requested a review from a team as a code owner February 10, 2025 18:30
@Matt711 Matt711 requested a review from jameslamb February 10, 2025 18:30
@Matt711 Matt711 added bug Something isn't working non-breaking Non-breaking change labels Feb 10, 2025
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Feb 10, 2025
@Matt711 Matt711 changed the title Install duckdb the default backend for ibis in the cudf.pandas integr… Install duckdb the default backend for ibis in the cudf.pandas interation tests Feb 10, 2025
@bdice bdice changed the title Install duckdb the default backend for ibis in the cudf.pandas interation tests Install duckdb the default backend for ibis in the cudf.pandas integration tests Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (branch-25.04@b82d0e7). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-25.04   #17972   +/-   ##
===============================================
  Coverage                ?   86.96%           
===============================================
  Files                   ?      312           
  Lines                   ?    37023           
  Branches                ?        0           
===============================================
  Hits                    ?    32198           
  Misses                  ?     4825           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Matt711 Matt711 added the DO NOT MERGE Hold off on merging; see PR for details label Feb 10, 2025
@Matt711
Copy link
Contributor Author

Matt711 commented Feb 10, 2025

I'm marking this as DO NOT MERGE for now until I fix the failing ibis integration tests.

raydouglass pushed a commit that referenced this pull request Feb 10, 2025
Follows up #17972. This PR is intended to get 25.02 nightly CI passing,
which has been failing for few days.
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_ibis.py, you'll need to change ibis.set_backend("pandas") to ibis.set_backend("duckdb") or maybe ibis.set_backend(ibis.duckdb.connect())

EDIT: Actually, just fold in your changes from #17945?

@Matt711 Matt711 requested a review from a team as a code owner February 14, 2025 14:18
@Matt711 Matt711 requested review from vyasr and mroeschke February 14, 2025 14:18
@Matt711
Copy link
Contributor Author

Matt711 commented Feb 14, 2025

I think in python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_ibis.py, you'll need to change ibis.set_backend("pandas") to ibis.set_backend("duckdb") or maybe ibis.set_backend(ibis.duckdb.connect())

EDIT: Actually, just fold in your changes from #17945?

Thanks I just removed set_backend("pandas") so ibis should use duckdb. Now I'm checking to see which tests I need to fix.

@Matt711 Matt711 removed the DO NOT MERGE Hold off on merging; see PR for details label Feb 15, 2025
@Matt711
Copy link
Contributor Author

Matt711 commented Feb 15, 2025

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cudf.pandas Issues specific to cudf.pandas non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants