-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install duckdb the default backend for ibis in the cudf.pandas integration tests #17972
base: branch-25.04
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-25.04 #17972 +/- ##
===============================================
Coverage ? 86.96%
===============================================
Files ? 312
Lines ? 37023
Branches ? 0
===============================================
Hits ? 32198
Misses ? 4825
Partials ? 0 ☔ View full report in Codecov by Sentry. |
I'm marking this as DO NOT MERGE for now until I fix the failing ibis integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_ibis.py
, you'll need to change ibis.set_backend("pandas")
to ibis.set_backend("duckdb")
or maybe ibis.set_backend(ibis.duckdb.connect())
EDIT: Actually, just fold in your changes from #17945?
Thanks I just removed |
/merge |
Follows up #17945
Description
Checklist