Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump polars version to <1.23 #17986

Open
wants to merge 14 commits into
base: branch-25.04
Choose a base branch
from

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Feb 11, 2025

Description

The PR upgrades the Polars version to 1.22.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Feb 11, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Feb 11, 2025
@mroeschke
Copy link
Contributor

mroeschke commented Feb 11, 2025

IIRC when working on the sink engines on polars main, the polars IR version got bumped (i.e. you'll need to bump the version check in Translator.translate_ir)

@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Feb 13, 2025
@Matt711
Copy link
Contributor Author

Matt711 commented Feb 13, 2025

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 14, 2025

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 14, 2025

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 14, 2025

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 15, 2025

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 15, 2025

/ok to test

@Matt711 Matt711 marked this pull request as ready for review February 15, 2025 04:17
@Matt711 Matt711 requested review from a team as code owners February 15, 2025 04:17
@Matt711
Copy link
Contributor Author

Matt711 commented Feb 15, 2025

Polars 1.22 is not installed in this CI job https://github.com/rapidsai/cudf/actions/runs/13341319519/job/37267041016?pr=17986#step:9:5952. Is this related to #18014?

Edit: Yes it was.

CC @jameslamb

@github-actions github-actions bot added the cudf.pandas Issues specific to cudf.pandas label Feb 16, 2025
@github-actions github-actions bot removed the cudf.pandas Issues specific to cudf.pandas label Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.polars Issues specific to cudf.polars feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants