[Bug] Fix Parquet-metadata sampling in cudf-polars #17991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
added
bug
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Matt711
approved these changes
Feb 12, 2025
galipremsagar
approved these changes
Feb 12, 2025
|
/okay to test |
rjzamora
added
5 - Ready to Merge
|
/merge |
|
Anyone know what's missing for this to merge? (I'd rather not re-run all tests again for such a trivial fix) |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The experimental multi-GPU executor for cudf-polars always attempts to sample the metadata from three files when reading from a Parquet dataset. This is obviously a problem when there are fewer than three files to sample from.
This PR fixes the trivial bug and adds test coverage.
Checklist