Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cudf::lists::detail::make_empty_lists_column to public API #17996

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Move cudf::lists::detail::make_empty_lists_column to public API #17996

merged 2 commits into from
Feb 14, 2025

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Feb 12, 2025 •
edited by lamarrr
Loading

Description

This copies the existing make_empty_lists_column in the detail namespace to the public cudf namespace.
The cudf::make_empty_column does not support lists or structs types.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 12, 2025
@davidwendt davidwendt self-assigned this Feb 12, 2025
@davidwendt davidwendt requested a review from a team as a code owner February 12, 2025 20:21
@davidwendt
Copy link
Contributor Author

/merge

1 similar comment
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 3e40b30 into rapidsai:branch-25.04 Feb 14, 2025
108 of 109 checks passed
@davidwendt davidwendt deleted the make-empty-lists-public branch February 14, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@PointKernel PointKernel PointKernel approved these changes

@lamarrr lamarrr lamarrr approved these changes

@kingcrimsontianyu kingcrimsontianyu Awaiting requested review from kingcrimsontianyu kingcrimsontianyu is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @vyasr @PointKernel @lamarrr