Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nightly check limit #18213

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Mar 10, 2025

Description

Bumps the nightly check limit while we investigate/fix cuDF CI failures

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added bug Something isn't working non-breaking Non-breaking change labels Mar 10, 2025
@Matt711 Matt711 requested a review from a team as a code owner March 10, 2025 18:19
@Matt711 Matt711 requested a review from bdice March 10, 2025 18:19
@jameslamb jameslamb requested review from jameslamb and removed request for bdice March 10, 2025 18:20
@Matt711
Copy link
Contributor Author

Matt711 commented Mar 10, 2025

I'll open a PR to revert afterwards.

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, there's enough stuff referencing these CI failures (e.g. rapidsai/docker#742 (comment) and rapidsai/docker#738 (comment) and other conversations) that I think it'd be helpful to have a tracking issue here in cudf linking everything together (and to mention that in the comment being added to .github/workflows/pr.yaml here).

But approving so you can merge this whenever you want without needing a re-approval, and even if you decide against a comment like that (to avoid another CI run).

@Matt711
Copy link
Contributor Author

Matt711 commented Mar 10, 2025

At this point, there's enough stuff referencing these CI failures (e.g. rapidsai/docker#742 (comment) and rapidsai/docker#738 (comment) and other conversations) that I think it'd be helpful to have a tracking issue here in cudf linking everything together (and to mention that in the comment being added to .github/workflows/pr.yaml here).

But approving so you can merge this whenever you want without needing a re-approval, and even if you decide against a comment like that (to avoid another CI run).

Good idea. Will do

@Matt711
Copy link
Contributor Author

Matt711 commented Mar 10, 2025

/merge

@rapids-bot rapids-bot bot merged commit 7aabb43 into rapidsai:branch-25.04 Mar 10, 2025
113 checks passed
Matt711 added a commit that referenced this pull request Mar 10, 2025
rapids-bot bot pushed a commit that referenced this pull request Mar 13, 2025
Reverts #18213 We should merge this PR after we fix the nightly CI failures.

xref #18215

Authors:
  - Matthew Murray (https://github.com/Matt711)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #18227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants