Implement JNI for strings:repeat_strings that repeats each string separately by different numbers of times
#8572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
feature request
ttnghia
changed the title
strings:repeat_strings that repeats each string separately by different number of timesstrings:repeat_strings that repeats each string separately by different number of times [skip ci]
ttnghia
requested review from
vyasr and
brandon-b-miller
and removed request for
a team
github-actions
bot
removed
CMake
ttnghia
changed the title
strings:repeat_strings that repeats each string separately by different numbers of times [skip ci]strings:repeat_strings that repeats each string separately by different numbers of times
|
Rerun tests. |
jlowe
reviewed
Jul 23, 2021
jlowe
reviewed
Jul 23, 2021
jlowe
approved these changes
Jul 23, 2021
|
Rerun tests. |
|
@gpucibot merge |
|
Rerun tests. |
1 similar comment
|
Rerun tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up work on #8491 so that cudf's
strings::repeat_stringsfully supports StringRepeat SQL expression in Apache Spark.This PR also rewrites some existing code, including re-formatting code and changes in doxygen.