Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require approval to run CI on draft PRs #6145

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 26, 2024

By default, CI runs on draft PRs. This leads to many CI runs that may be unnecessary.

With this PR's change to .github/copy-pr-bot.yaml, an /ok to test comment from a trusted user is required to trigger CI on draft PRs. Non-draft PRs will run CI by default, assuming that all commits are signed by trusted users. Otherwise an /ok to test is required (as before) -- see the copy-pr-bot docs at https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/ for more information.

Part of rapidsai/build-planning#123.

@bdice bdice requested a review from a team as a code owner November 26, 2024 18:59
@bdice bdice requested a review from AyodeAwe November 26, 2024 18:59
@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Nov 26, 2024
@bdice
Copy link
Contributor Author

bdice commented Nov 26, 2024

/merge

@bdice
Copy link
Contributor Author

bdice commented Nov 26, 2024

E   ImportError: libcudf.so: cannot open shared object file: No such file or directory

This tried to run with two different alpha builds of cudf (25.2.0a73) and libcudf (25.2.0a75). This is a temporary failure that will be resolved by new builds of libcudf. I'll request an admin-merge in the meantime.

@raydouglass raydouglass merged commit ae9c1ea into rapidsai:branch-25.02 Nov 26, 2024
58 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants