Improve cuvs-bench doc and add executable dir option #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfeher
added
doc
divyegala
reviewed
Feb 12, 2025
| Testing on new datasets | ||
| ----------------------- | ||
|
|
||
| To run benchmark on a dataset, it is required have a descriptor that defines the file names and a few other properties of that datase. |
There was a problem hiding this comment.
Suggested change
| To run benchmark on a dataset, it is required have a descriptor that defines the file names and a few other properties of that datase. | |
| To run benchmark on a dataset, it is required have a descriptor that defines the file names and a few other properties of that dataset. |
| show_default=True, | ||
| prompt="Enter the name of the folder that contains the executables", | ||
| help="Path to executable folder, by default we will look in " | ||
| "$CUVS_HOME/cpp/build/release and $CONDA_PREFIX/bin/ann.", |
There was a problem hiding this comment.
Is it build/release or just build? Also do we look in build first then conda prefix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first two points in #679