[ci] run container-canary tests on built images #670
Merged
+281
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
force-pushed
the
container-canary
branch
from
c968434 to
3f3c9bc
Compare
jameslamb
force-pushed
the
container-canary
branch
from
d2f5371 to
bc3d1d7
Compare
jameslamb
added
improvement
non-breaking
and removed
2 - In Progress
jameslamb
commented
Mar 26, 2025
jameslamb
changed the title
jameslamb
commented
Mar 26, 2025
AyodeAwe
approved these changes
Mar 26, 2025
jacobtomlinson
approved these changes
Mar 31, 2025
AyodeAwe
approved these changes
Mar 31, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #667.
Proposes adding some
container-canarytests to check that changes to this project don't introduce user-facing regressions.Benefits of these changes
See #667 for more details.
In short, the images produced in this repo are intended to be used in a wide variety of environments, including many bring-your-own-container cloud services. Each of those services has slightly different expectations for container images (permissions, default user, existence/non-existence of paths, etc.).
See, for example, the RAPIDS deployment docs:
container-canaryallows us to express all of those expectations as tests that run in CI here, to ensure that new releases of these images don't break compatibility.Notes for Reviewers
Why isn't this testing against any checks for cloud providers?
The
container-canarydoes publish this helpful set of test cases: https://github.com/NVIDIA/container-canary/tree/main/examplesHowever, we can't run the RAPIDS
baseimage against them until NVIDIA/container-canary#62 is resolved.Proposing deferring that to later PRs.