Skip to content

Commit

Permalink
test download error handling shared action
Browse files Browse the repository at this point in the history
  • Loading branch information
msarahan committed Feb 10, 2025
1 parent 3953d1c commit a1259fa
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 17 deletions.
35 changes: 22 additions & 13 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
SHARED_ACTIONS_REF: better-download-error-handling

jobs:
pr-builder:
needs:
Expand Down Expand Up @@ -40,7 +43,7 @@ jobs:
# This gate is here and not at the job level because we need the job to not be skipped,
# since other jobs depend on it.
if: ${{ vars.TELEMETRY_ENABLED == 'true' }}
uses: rapidsai/shared-actions/telemetry-dispatch-stash-base-env-vars@main
uses: rapidsai/shared-actions/telemetry-dispatch-stash-base-env-vars@better-download-error-handling
check-nightly-ci:
# Switch to ubuntu-latest once it defaults to a version of Ubuntu that
# provides at least Python 3.11 (see
Expand All @@ -57,7 +60,11 @@ jobs:
needs:
- telemetry-setup
secrets: inherit
<<<<<<< HEAD
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
=======
uses: rapidsai/shared-workflows/.github/workflows/changed-files.yaml@github-token-attr-split
>>>>>>> 25c99514 (test download error handling shared action)
with:
files_yaml: |
test_cpp:
Expand All @@ -79,40 +86,40 @@ jobs:
secrets: inherit
needs:
- telemetry-setup
uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@github-token-attr-split
with:
enable_check_generated_files: false
ignored_pr_jobs: telemetry-summarize
conda-cpp-build:
conda-cpp-build:
needs: checks
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@github-token-attr-split
with:
build_type: pull-request
conda-cpp-tests:
needs: [conda-cpp-build, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@github-token-attr-split
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_cpp
with:
build_type: pull-request
conda-python-build:
needs: conda-cpp-build
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@github-token-attr-split
with:
build_type: pull-request
conda-python-tests:
needs: [conda-python-build, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@github-token-attr-split
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python
with:
build_type: pull-request
docs-build:
needs: conda-python-build
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@github-token-attr-split
with:
build_type: pull-request
node_type: "gpu-l4-latest-1"
Expand All @@ -122,22 +129,22 @@ jobs:
wheel-build-cpp:
needs: checks
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@github-token-attr-split
with:
matrix_filter: group_by([.ARCH, (.CUDA_VER|split(".")|map(tonumber)|.[0])]) | map(max_by(.PY_VER|split(".")|map(tonumber)))
build_type: pull-request
script: ci/build_wheel_cpp.sh
wheel-build-python:
needs: wheel-build-cpp
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@github-token-attr-split
with:
build_type: pull-request
script: ci/build_wheel_python.sh
wheel-tests:
needs: [wheel-build-python, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@github-token-attr-split
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python
with:
build_type: pull-request
Expand All @@ -146,7 +153,7 @@ jobs:
secrets: inherit
needs:
- telemetry-setup
uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@branch-25.04
uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@github-token-attr-split
with:
arch: '["amd64"]'
cuda: '["12.8"]'
Expand All @@ -163,4 +170,6 @@ jobs:
continue-on-error: true
steps:
- name: Telemetry summarize
uses: rapidsai/shared-actions/telemetry-dispatch-summarize@main
uses: rapidsai/shared-actions/telemetry-dispatch-summarize@better-download-error-handling
with:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion ci/build_cpp.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ sccache --zero-stats
# This calls mambabuild when boa is installed (as is the case in the CI images)
RAPIDS_PACKAGE_VERSION=$(rapids-generate-version) rapids-conda-retry mambabuild conda/recipes/librmm

sccache --show-adv-stats
sccache --show-adv-stats | tee telemetry-artifacts/sccache-stats.txt

rapids-upload-conda-to-s3 cpp
2 changes: 1 addition & 1 deletion ci/build_python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ sccache --zero-stats
# This calls mambabuild when boa is installed (as is the case in the CI images)
RAPIDS_PACKAGE_VERSION=$(head -1 ./VERSION) rapids-conda-retry mambabuild -c "${CPP_CHANNEL}" conda/recipes/rmm

sccache --show-adv-stats
sccache --show-adv-stats | tee telemetry-artifacts/sccache-stats.txt

rapids-upload-conda-to-s3 python
2 changes: 1 addition & 1 deletion ci/build_wheel_cpp.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ sccache --zero-stats

rapids-pip-retry wheel . -w dist -v --no-deps --disable-pip-version-check

sccache --show-adv-stats
sccache --show-adv-stats | tee telemetry-artifacts/sccache-stats.txt

python -m wheel tags --platform any dist/* --remove

Expand Down
2 changes: 1 addition & 1 deletion ci/build_wheel_python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ sccache --zero-stats
PIP_CONSTRAINT="${PWD}/build-constraints.txt" \
rapids-pip-retry wheel . -w dist -v --no-deps --disable-pip-version-check

sccache --show-adv-stats
sccache --show-adv-stats | tee telemetry-artifacts/sccache-stats.txt

mkdir -p final_dist
python -m auditwheel repair -w final_dist dist/*
Expand Down

0 comments on commit a1259fa

Please sign in to comment.