Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPERIMENT] Using Github Artifact Store to store build artifacts #1810

Draft
wants to merge 7 commits into
base: branch-25.04
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 53 additions & 53 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ jobs:
- conda-python-build
- conda-python-tests
- docs-build
- wheel-build-cpp
- wheel-build-python
- wheel-tests
- devcontainer
# - wheel-build-cpp
# - wheel-build-python
# - wheel-tests
# - devcontainer
- telemetry-setup
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@nvks-runners
Expand Down Expand Up @@ -86,81 +86,81 @@ jobs:
conda-cpp-build:
needs: checks
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@nvks-runners
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@test-github-artifacts
with:
build_type: pull-request
conda-cpp-tests:
needs: [conda-cpp-build, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@nvks-runners
uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@test-github-artifacts
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_cpp
with:
build_type: pull-request
conda-python-build:
needs: conda-cpp-build
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@nvks-runners
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@test-github-artifacts
with:
build_type: pull-request
conda-python-tests:
needs: [conda-python-build, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@nvks-runners
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@test-github-artifacts
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python
with:
build_type: pull-request
docs-build:
needs: conda-python-build
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@nvks-runners
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@test-github-artifacts
with:
build_type: pull-request
node_type: "gpu-l4-latest-1"
arch: "amd64"
container_image: "rapidsai/ci-conda:latest"
run_script: "ci/build_docs.sh"
wheel-build-cpp:
needs: checks
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@nvks-runners
with:
matrix_filter: group_by([.ARCH, (.CUDA_VER|split(".")|map(tonumber)|.[0])]) | map(max_by(.PY_VER|split(".")|map(tonumber)))
build_type: pull-request
script: ci/build_wheel_cpp.sh
wheel-build-python:
needs: wheel-build-cpp
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@nvks-runners
with:
build_type: pull-request
script: ci/build_wheel_python.sh
wheel-tests:
needs: [wheel-build-python, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@nvks-runners
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python
with:
build_type: pull-request
script: ci/test_wheel.sh
devcontainer:
secrets: inherit
needs:
- telemetry-setup
uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@nvks-runners
with:
arch: '["amd64"]'
cuda: '["12.8"]'
build_command: |
sccache -z;
build-all -DBUILD_BENCHMARKS=ON --verbose;
sccache -s;
# wheel-build-cpp:
# needs: checks
# secrets: inherit
# uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@nvks-runners
# with:
# matrix_filter: group_by([.ARCH, (.CUDA_VER|split(".")|map(tonumber)|.[0])]) | map(max_by(.PY_VER|split(".")|map(tonumber)))
# build_type: pull-request
# script: ci/build_wheel_cpp.sh
# wheel-build-python:
# needs: wheel-build-cpp
# secrets: inherit
# uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@nvks-runners
# with:
# build_type: pull-request
# script: ci/build_wheel_python.sh
# wheel-tests:
# needs: [wheel-build-python, changed-files]
# secrets: inherit
# uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@nvks-runners
# if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python
# with:
# build_type: pull-request
# script: ci/test_wheel.sh
# devcontainer:
# secrets: inherit
# needs:
# - telemetry-setup
# uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@nvks-runners
# with:
# arch: '["amd64"]'
# cuda: '["12.8"]'
# build_command: |
# sccache -z;
# build-all -DBUILD_BENCHMARKS=ON --verbose;
# sccache -s;

telemetry-summarize:
# This job must use a self-hosted runner to record telemetry traces.
runs-on: linux-amd64-cpu4
needs: pr-builder
if: ${{ vars.TELEMETRY_ENABLED == 'true' && !cancelled() }}
continue-on-error: true
steps:
- name: Telemetry summarize
uses: rapidsai/shared-actions/telemetry-dispatch-summarize@main
# telemetry-summarize:
# # This job must use a self-hosted runner to record telemetry traces.
# runs-on: linux-amd64-cpu4
# needs: pr-builder
# if: ${{ vars.TELEMETRY_ENABLED == 'true' && !cancelled() }}
# continue-on-error: true
# steps:
# - name: Telemetry summarize
# uses: rapidsai/shared-actions/telemetry-dispatch-summarize@main
4 changes: 2 additions & 2 deletions ci/build_docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ conda activate docs
rapids-print-env

rapids-logger "Downloading artifacts from previous jobs"
CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp)
PYTHON_CHANNEL=$(rapids-download-conda-from-s3 python)
CPP_CHANNEL=$(rapids-download-conda-from-github cpp)
PYTHON_CHANNEL=$(rapids-download-conda-from-github python)

rapids-mamba-retry install \
--channel "${CPP_CHANNEL}" \
Expand Down
2 changes: 1 addition & 1 deletion ci/build_python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ rapids-generate-version > ./VERSION

rapids-logger "Begin py build"

CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp)
CPP_CHANNEL=$(rapids-download-conda-from-github cpp)

sccache --zero-stats

Expand Down
2 changes: 1 addition & 1 deletion ci/test_cpp.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ set +u
conda activate test
set -u

CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp)
CPP_CHANNEL=$(rapids-download-conda-from-github cpp)
RAPIDS_TESTS_DIR=${RAPIDS_TESTS_DIR:-"${PWD}/test-results"}/
mkdir -p "${RAPIDS_TESTS_DIR}"

Expand Down
4 changes: 2 additions & 2 deletions ci/test_python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ set -u
rapids-print-env

rapids-logger "Downloading artifacts from previous jobs"
CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp)
PYTHON_CHANNEL=$(rapids-download-conda-from-s3 python)
CPP_CHANNEL=$(rapids-download-conda-from-github cpp)
PYTHON_CHANNEL=$(rapids-download-conda-from-github python)

rapids-mamba-retry install \
--channel "${CPP_CHANNEL}" \
Expand Down
Loading