-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable setting styles for filter button as a configuration. #2182
base: development
Are you sure you want to change the base?
Enable setting styles for filter button as a configuration. #2182
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #2182 +/- ##
=================================================
+ Coverage 90.98% 91.00% +0.01%
- Complexity 2011 2015 +4
=================================================
Files 218 220 +2
Lines 4539 4549 +10
=================================================
+ Hits 4130 4140 +10
Misses 409 409 ☔ View full report in Codecov by Sentry. |
Please add in the tests, as otherwise it'll queue until I have time to add them in! |
Also noting that there's a significant change pending relating to Filter trait namespaces, so I may need to adjust this PR pretty significantly to get it in line with the pending change. |
Thanks, I will work on tests and change the required namespaces depending on #2181 ASAP (3 days at most). |
Tests for (filter button and filter button badge styling) were added, Please feel free to adjust Filter trait namespaces to align with the pending change. |
What I'll do, is merge in the other PR which covers off all of the new namespaces etc, then I'll do some tweaks on this one to merge it in. You may notice that the other PR also adjusts your other attribute methods to use the centralised approach. I'm trying to migrate any new attributes etc to this approach, as it should make keeping everything standardised a little easier. At the moment, there's a mix of "default" being true/false, so I'm trying to use some core methods so that it is standard (For anything new at least) Great work btw on all of the new attributes, and really appreciated. |
So with all of the recent underpinning work, this has a few conflicts. Once everything else is fully tested/released, then I'll come back to this and look at differences and merge appropriate changes in. |
Perfect, Thanks for the updates. |
Hi,
This PR represents an implementation to enable setting the styles for filter button and filter button badge as a configuration through the following functions:
setFilterButtonAttributes(...)
setFilterButtonBadgeAttributes(...)
All Submissions:
New Feature Submissions: