Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.6.5 #2197

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

v3.6.5 #2197

wants to merge 25 commits into from

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Feb 9, 2025

v3.6.5 Release

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

HussamAlhennawi and others added 20 commits January 14, 2025 21:41
…n-select-styling

Enable setting styles for column select as a configuration.
…ng-pills-styling

Enable setting styles for sorting pills as a configuration.
…r-pills-styling

Enable setting styles for filter pills as a configuration.
Flex is only for tailwind, this wa broken when splitting out the styles for the search icon
…Area

Add "after-tools" configurable area
Fix Search Field in bootstrap
* Initial Commits

* Fix styling

* Fix namespace

* Fix styling

* Remove superfluous filter traits

* Fixes for Filter Trait Tidy Up

* Fix styling

* Tweaks for Lazy Tables & Tidying Item

* Roll back to allow HTML separator

* Add tests for new methods

* Fix styling

* Remove duplicate traits

* Add additional tests

* Add filter slidedown tests

* Fix styling

* Add Filter Slidedown Row Test

* Fix styling

* Test Adjustments

* Add test for filter slidedown row

* Fix styling

* Merging

* Add setFilterDefaultValue Test

* Fix styling
* Fixes for QueryString & Centralising Methods

* Tweaks for Filters
* Initial Migration for FilterView Traits

* Fix styling
* Partial Merges

* Fix styling

* Minor adjustments

* Fix styling

* Minor tweaks for return type

* Minor dochint fixes

* Migration to support Livewire Filter Array filter pills, docs updates, and reverting away from computed properties for the theme determination

* Fix styling

* Minor tweaks to handle HTML array separators

* Fix broken separator

* Minor tweaks

* Tweaks & Adjustments

* Fix styling

* Minor Tweaks to Tests

* Fix styling

* Test Fixes

* Fix styling

* Test Tweaks

* Fix styling

* Tweaks for tests

* Fix styling

* Tweaks to Base

* Fix styling
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 80.94714% with 173 lines in your changes missing coverage. Please review.

Project coverage is 89.94%. Comparing base (6598b25) to head (3ecfb1d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...TransferObjects/Filters/StandardFilterPillData.php 0.00% 18 Missing ⚠️
src/Traits/Core/HasCustomAttributes.php 50.00% 18 Missing ⚠️
...Traits/Filters/HandlesLivewireComponentFilters.php 0.00% 17 Missing ⚠️
.../Traits/HandlesCorePropertiesForExternalFilter.php 0.00% 15 Missing ⚠️
src/Traits/Filters/HasFilterCore.php 0.00% 14 Missing ⚠️
src/Views/Columns/LivewireComponentColumn.php 52.38% 10 Missing ⚠️
src/Traits/Styling/HasSortingPillsStyling.php 40.00% 9 Missing ⚠️
src/Traits/Filters/Helpers/FilterPillsHelpers.php 73.33% 8 Missing ⚠️
...ers/Traits/HandlesTableEventsForExternalFilter.php 0.00% 7 Missing ⚠️
src/Traits/Filters/Helpers/FilterMenuHelpers.php 78.12% 7 Missing ⚠️
... and 15 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2197      +/-   ##
============================================
- Coverage     91.44%   89.94%   -1.51%     
- Complexity     1995     2149     +154     
============================================
  Files           212      242      +30     
  Lines          4499     4851     +352     
============================================
+ Hits           4114     4363     +249     
- Misses          385      488     +103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Migrate Namespaces for Columns & Filters

* Fix styling

* Remove duplicated Trait

* Cleanup errant folder

* Restore Component to Column for historic purposes

* Fix styling

* Restore DataTableComponent, Adjust Column Tests to use ColumnTestCase

* Fix styling

* Additional Trait Splits

* Fix styling

* Migrate more methods into traits

* Fix styling

* Further Column Trait Tidy Up

* Fix styling

* Add test for deprecated sorting pills direction test

* Fix styling

* Tidying Styling Traits

* Fix styling
…aviours (#2203)

* Tweaks for BulkActions

* Fix styling

* Tweaks for Bulk Actions

* Fix styling
* Add setFilterPillTitleAsHtml

* Fix styling

* Add Filter Pill Handler

* Fix styling

* Adjust for new Pill View Component

* Adjust FilterPillDataTest

* Fix styling

* Temporarily disable filter pill separator test
* Tweak Return Types

* Tweak type
* Tweak for text pill title

* Fix styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants