✨ feat(route): allows duplicate routes across users #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallabpain
force-pushed
the
feat/user-subnets
branch
4 times, most recently
from
5cb177e to
741eb57
Compare
pallabpain
force-pushed
the
feat/user-subnets
branch
from
741eb57 to
a7ed52f
Compare
pallabpain
changed the title
pallabpain
changed the title
pallabpain
force-pushed
the
feat/user-subnets
branch
4 times, most recently
from
e7359f2 to
1be2446
Compare
pallabpain
force-pushed
the
feat/user-subnets
branch
from
1be2446 to
4c0a21b
Compare
pallabpain
approved these changes
Dec 11, 2023
smrutisenapati
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Headscale follows tailscale control server architecture where if more than one subnet router irrespective of the user it belongs to, tries to advertise the same subnet range, only one of them can become a primary router. This is problematic for rapyuta.io VPN use cases where multiple warehouses aka users/namespaces in control server terminology can use the same subnet ranges.
This PR tries to solve this use case by checking conflicting subnet ranges within a namespace/user scope instead of all the users/namespaces.
Wrike: