🐛 fix(routes): corrects the logic in handlePrimarySubnetFailover #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallabpain
force-pushed
the
fix/unique-prefix
branch
from
9f421e0 to
5a63c30
Compare
amitsingh21
approved these changes
Jan 11, 2024
pallabpain
force-pushed
the
fix/unique-prefix
branch
2 times, most recently
from
c3c286e to
b6e39eb
Compare
pallabpain
force-pushed
the
fix/unique-prefix
branch
from
b6e39eb to
0a057c6
Compare
pallabpain
changed the title
ankitrgadiya
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple of things
isUniquePrefixwas checking the state of the incorrect route machinehandlePrimarySubnetFailoverfunction was not checking for user ID when finding the new primary route for failover