Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(paramserver): raise exception during download when trees not found #73

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

pallabpain
Copy link
Member

@pallabpain pallabpain commented Jan 19, 2024

Description

When no matching tree names are found in download_configurations, the code will now raise a ConfigNotFoundException. This will assure that clients get a proper error instead of not knowing what happened.

Wrike Ticket: https://www.wrike.com/open.htm?id=1182864968

@pallabpain pallabpain requested review from a team as code owners January 19, 2024 16:57
@pallabpain pallabpain requested review from ankitrgadiya and smrutisenapati and removed request for a team January 19, 2024 16:57
@pallabpain pallabpain self-assigned this Jan 19, 2024
@pallabpain pallabpain added the bug Something isn't working label Jan 19, 2024
@pallabpain pallabpain changed the base branch from master to devel January 22, 2024 04:09
When no matching tree names are found in download_configurations, the
code will now raise a ConfigNotFoundException. This will assure that
clients get a proper error instead of not knowing what happened.

Wrike Ticket: https://www.wrike.com/open.htm?id=1182864968
@pallabpain pallabpain merged commit 42f2c41 into devel Jan 22, 2024
4 checks passed
rr-github-ci-user pushed a commit that referenced this pull request Jan 22, 2024
# [1.14.0](v1.13.0...v1.14.0) (2024-01-22)

### Bug Fixes

* **paramserver:** raise exception during download when trees not found ([#73](#73)) ([42f2c41](42f2c41))

### Features

* **params:** use binary file-upload if file is large ([f276b33](f276b33))
@rr-github-ci-user
Copy link

🎉 This PR is included in version 1.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants