Improves container error message for easier debugging

[micpalmia]

In case the engine is not shut down correctly, config and data
container folders are left in their directories, making it impossible to
execute the same code again after a problematic exit. The new error
message containes the path to the folder where the container
directories reside.

In order to prevent people deleting directories that are still in use,
a short informative message is also provided.

This addresses but does not solve issue #39

[dhananjaysathe]

This looks good , also we need to take a call for a permanent fix, are we
to always delete this , or an alternate is to maintain a runtime lock in
/tmp that we test against , if false we clean up the mess before launching
? This would fix it and remove the case that the container that is running
due to some active process is not halted or interfered with by mistake ,
its rather trivial to implement , I need a consensus on what you folks
think.

Cheers !

Best
-D

On Tue, Sep 17, 2013 at 7:34 PM, Michele Palmia [email protected]:

In case the engine is not shut down correctly, config and data
container folders are left in their directories, making it impossible to
execute the same code again after a problematic exit. The new error
message containes the path to the folder where the container
directories reside.

In order to prevent people deleting directories that are still in use,
a short informative message is also provided.

This addresses but does not solve issue #39#39

You can merge this Pull Request by running

git pull https://github.com/Boanerghes/rce helpcontainerfix

Or view, comment on, or merge it at:

#40
Commit Summary

• Improves container error message for easier debugging

File Changes

• M rce-core/rce/container.pyhttps://github.com/Improves container error message for easier debugging #40/files#diff-0(9)

Patch Links:

• https://github.com/IDSCETHZurich/rce/pull/40.patch
• https://github.com/IDSCETHZurich/rce/pull/40.diff

[dominiquehunziker]

The container folders are also some form of runtime lock... The problem
should only occur when the container process is terminated using SIGKILL (I
don't know about SIGTERM, never needed this; SIGINT should be handeled
gracefully). Would your /tmp lock mechanism work in all these cases?
(eclipse does something similar for workspaces and SIGKILL is also a
problem there...)

One thing we should add for sure is some type of insurance that either only
rce-make or rce-container is running.

On a side note: Just thought of the issue where you would run eg the
master, then change the config file, and then some other process, which
might result in a conflict that the config is inconsistent between the two
processes...
On 17 Sep 2013 16:11, "Dhananjay Sathe" [email protected] wrote:

This looks good , also we need to take a call for a permanent fix, are we
to always delete this , or an alternate is to maintain a runtime lock in
/tmp that we test against , if false we clean up the mess before launching
? This would fix it and remove the case that the container that is running
due to some active process is not halted or interfered with by mistake ,
its rather trivial to implement , I need a consensus on what you folks
think.

Cheers !

Best
-D

On Tue, Sep 17, 2013 at 7:34 PM, Michele Palmia <[email protected]

wrote:

In case the engine is not shut down correctly, config and data
container folders are left in their directories, making it impossible to
execute the same code again after a problematic exit. The new error
message containes the path to the folder where the container
directories reside.

In order to prevent people deleting directories that are still in use,
a short informative message is also provided.

This addresses but does not solve issue #39<

https://github.com/IDSCETHZurich/rce/issues/39>

You can merge this Pull Request by running

git pull https://github.com/Boanerghes/rce helpcontainerfix

Or view, comment on, or merge it at:

#40
Commit Summary

• Improves container error message for easier debugging

File Changes

• M rce-core/rce/container.py<
  https://github.com/IDSCETHZurich/rce/pull/40/files#diff-0>(9)

Patch Links:

• https://github.com/IDSCETHZurich/rce/pull/40.patch
• https://github.com/IDSCETHZurich/rce/pull/40.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/40#issuecomment-24590882
.