Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating point issue in costmap_2d boundaries #101

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

renan028
Copy link
Member

@renan028 renan028 commented Oct 18, 2024

Description

AB#20987
Intersection points are in the boundary of the map, thus we might have floating point issue.
And this check will fail:

// check for legality just in case
    if (!worldToMap(wx, wy, x1, y1) || !worldToMap(ox, oy, x0, y0))
      continue;

Video of the issue:

issue_1-2024-10-18_15.58.05.mp4

After the fix:

issue_2-2024-10-18_15.52.45.mp4

@renan028 renan028 requested a review from a team October 18, 2024 07:01
@renan028 renan028 requested a review from a team October 25, 2024 06:53
@renan028 renan028 merged commit bd2acbc into devel Oct 28, 2024
1 check passed
@renan028 renan028 deleted the rs/fix_floating branch October 28, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants