Improved bcm2836/7 IRQ handling #6359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is exciting! I imagine this might help with the |
|
At this stage it's more likely to just permute the set of errors you get. There's no guaranteed maximum interrupt latency with this patch series. |
popcornmix
approved these changes
Jun 5, 2025
Interrupts are dispatched round-robin but doing so trampled FIQ routing. Taking a FIQ on a core without a handler installed is fatal. Only modify bits 1:0 which are the IRQ route bits. Signed-off-by: Jonathan Bell <[email protected]>
BCM2836 with Cortex-A7 cores has almost the same ARM_LOCAL interrupt routing logic as BCM2837, so relax the compile guard to CONFIG_SMP not CONFIG_ARM64. Signed-off-by: Jonathan Bell <[email protected]>
Also declare as static inline, as they should be. Signed-off-by: Jonathan Bell <[email protected]>
The ARM64 architecture uses qspinlock which has a fast and slow path. This isn't ideal for all claimers of a lock operating in interrupt context. Add a ticket-based lock similar to the armv6/7 implementation. Based on an upstream patch that was abandoned in favour of qspinlock. Link: https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/ Signed-off-by: Jonathan Bell <[email protected]>
Warning on normal behaviour isn't sensible and is spammy. Demote to info. Signed-off-by: Jonathan Bell <[email protected]>
The local spinlock protects the handlers from racing against each other on separate cores, hard IRQs don't preempt each other, and disabling/enabling the interrupt is more expensive than letting the fake FIQ contend the spinlock. So turn local_fiq_en/disable into no-ops. Signed-off-by: Jonathan Bell <[email protected]>
|
Rebased on 6.12 and tested on a 3B+ (arm_64bit=1/0) and was functional in each case. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 6, 2025
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First phase of preparing to add platform FIQ support for armv8. Catch some low-hanging fruit first.
Posting as a PR to get autobuilds for all affected platforms (Pi 0 through 3). Only merge if you're feeling brave...