Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Only enable -Werror for debug builds #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: Only enable -Werror for debug builds #69

wants to merge 1 commit into from

Commits on Feb 6, 2024

  1. build: Only enable -Werror for debug builds 

    -Werror is very unhelpful for distributions and end users as newer
compilers will raise warnings that the maintainers may not see. The
warnings should get reported upstream, but they shouldn't block users
from using the software.

Rather than drop the flag entirely, I have enabled it only for debug
builds, e.g. -DCMAKE_BUILD_TYPE=Debug.

Signed-off-by: James Le Cuirot <[email protected]>
    @chewi
    chewi committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    0bbef73 View commit details
    Browse the repository at this point in the history