Skip to content

[SLI-Metrics] Ray service info #3604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 18, 2025
Merged

[SLI-Metrics] Ray service info #3604

merged 6 commits into from
May 18, 2025

Conversation

owenowenisme
Copy link
Contributor

@owenowenisme owenowenisme commented May 14, 2025 •
edited
Loading

Why are these changes needed?

Implemented ray service info as planned in KubeRay v1.4.0 SLI proposal

Tests:

❯ curl -s localhost:8080/metrics | grep kuberay
# HELP kuberay_service_info RayServiceInfo contains the information of the RayService.
# TYPE kuberay_service_info gauge
kuberay_service_info{name="rayservice-sample",namespace="default"} 1

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@owenowenisme owenowenisme changed the title added ray service info netrics [SLI-Metrics] Added ray service info May 14, 2025
@owenowenisme owenowenisme marked this pull request as ready for review May 14, 2025 12:19
@owenowenisme
Copy link
Contributor Author

@win5923 @troychiu PTAL

win5923
win5923 reviewed May 16, 2025
View reviewed changes
win5923
win5923 approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@win5923 win5923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owenowenisme owenowenisme force-pushed the SLI-Metrics/kuberay-service-info branch from c56702a to 28418cf Compare May 16, 2025 17:27
@owenowenisme owenowenisme changed the title [SLI-Metrics] Added ray service info [SLI-Metrics] Ray service info May 16, 2025
troychiu
troychiu reviewed May 16, 2025
View reviewed changes
@owenowenisme owenowenisme requested a review from troychiu May 17, 2025 01:57
troychiu
troychiu approved these changes May 17, 2025
View reviewed changes
Copy link
Contributor

@troychiu troychiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owenowenisme
Copy link
Contributor Author

@kevin85421 PTAL

@kevin85421
Copy link
Member

@owenowenisme would you mind resolving the conflict? Thanks!

@owenowenisme
added ray service info netrics
8525ea7 
Signed-off-by: You-Cheng Lin <[email protected]>
@owenowenisme
added test
3c42b18 
Signed-off-by: You-Cheng Lin <[email protected]>
@owenowenisme
update with ray cluster info
bbbe4f2 
Signed-off-by: You-Cheng Lin <[email protected]>
@owenowenisme
resolve comment
f8fbaad 
Signed-off-by: You-Cheng Lin <[email protected]>
@owenowenisme
resolve comment
08d5818 
Signed-off-by: You-Cheng Lin <[email protected]>
@owenowenisme
remove RayServiceReconcilerOptions
30a0a13 
Signed-off-by: You-Cheng Lin <[email protected]>
@owenowenisme owenowenisme force-pushed the SLI-Metrics/kuberay-service-info branch from 7ccbf8e to 30a0a13 Compare May 18, 2025 01:11
@owenowenisme
Copy link
Contributor Author

@kevin85421 Rebased.

@kevin85421 kevin85421 merged commit d9a1801 into ray-project:master May 18, 2025
24 checks passed
@owenowenisme owenowenisme deleted the SLI-Metrics/kuberay-service-info branch May 18, 2025 09:08
@win5923 win5923 mentioned this pull request May 19, 2025
Closed
9 tasks
pawelpaszki pushed a commit to opendatahub-io/kuberay that referenced this pull request May 26, 2025
@owenowenisme @pawelpaszki
[SLI-Metrics] Ray service info (ray-project#3604)
615e1ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

@win5923 win5923 win5923 approved these changes

@troychiu troychiu troychiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@owenowenisme @kevin85421 @win5923 @troychiu