Resolve the issue of table header width collapsing and flashing #1187
Conversation
…during the initial rendering when setting sticky=true for a table with a large number of columns.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Walkthrough此次更改涉及 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/FixedHolder/index.tsx (1 hunks)
Additional comments not posted (1)
src/FixedHolder/index.tsx (1)
152-152: 简化表格可见性条件此更改通过仅检查
mergedColumnWidth来简化表格的可见性条件。这可能提高渲染性能，因为减少了影响可见性的条件。但是，建议验证此更改对于noData为真但mergedColumnWidth不为真的场景的影响，以确保不会引入任何意外的可见性问题。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1187 +/- ##
==========================================
- Coverage 99.49% 97.70% -1.79%
==========================================
Files 36 75 +39
Lines 989 7417 +6428
Branches 305 1112 +807
==========================================
+ Hits 984 7247 +6263
- Misses 5 164 +159
- Partials 0 6 +6 ☔ View full report in Codecov by Sentry. |
Resolve the issue of table header width collapsing and flashing during the initial rendering when setting sticky=true for a table with a large number of columns.
Summary by CodeRabbit
FixedHolder组件中表格元素的可见性逻辑，现在表格仅在mergedColumnWidth为假时隐藏，提升了可用性。